Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Inner SEI lithium interstitial diffusivity [m2.s-1]" in Arrhenius form #4560

Closed
Mingzefei opened this issue Nov 3, 2024 · 2 comments
Labels

Comments

@Mingzefei
Copy link

Mingzefei commented Nov 3, 2024

Description

I want to refactor "Inner SEI lithium interstitial diffusivity [m2.s-1]" in Arrhenius form. I have found the reference value for the activation energy of this reaction and intend to refactor this param as a function of temperature.

The reason I have identified is that "Inner SEI lithium interstitial diffusivity [m2.s-1]" is hardcoded and cannot be rewritten as a function.

Motivation

All other diffusivity params are in function form, but the SEI diffusivity is in parameter form, which is somewhat strange.
And I am very keen to achieve this functionality.

Possible Implementation

I am considering delving into the local pybamm code for modifications.
Is there a better way to achieve this? Or can someone provide some guidance?

Additional context

No response

@kratman
Copy link
Contributor

kratman commented Nov 21, 2024

@Mingzefei There are a few PRs working on SEI and other degradation mechanisms at the moment. You might want to start by taking a look at some of them to see how your idea fits into the current progress:

These three PRs are all linked to some of the current degradation work. Once you see what is changing, then you can start to refactor and put up a PR.

PyBaMM also has a slack channel and some other forums where you could discuss it further, if needed

@DrSOKane
Copy link
Contributor

Hi Zefei, all SEI growth mechanisms have the same Arrhenius dependence, using the parameter "SEI growth activation energy [J.mol-1]". So the feature you are requesting has already been implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants