You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add the capability to directly import a PyProBEResult object as a source of experimental data for PyBOP.
Motivation
PyProBE provides a user-friendly interface to experimental data allowing fast filtering to the subset of data of interest for further analysis.
The PyProBE README format would also provide value, closing the loop between the experimental and the PyBaMM Experiment that PyBOP uses for fitting.
Possible implementation
Utility function to import PyProBE objects into the required format, following discussion that ensures common syntax between PyProBE and PyBOP. The PyProBE object can provide both the filtered raw data and corresponding PyBaMM step instructions.
Corresponding example demonstrating this integration.
Additional context
No response
The text was updated successfully, but these errors were encountered:
Hi Tom, thanks for opening this issue. PyProBE looks like an interesting package, we'd welcome a PR to flesh out the integration. Initially, I would recommend a notebook or script that can then be refactored to work within either the pybop.Dataset class or a utility method as you described. Nice job on the package!
Feature description
Add the capability to directly import a PyProBE
Result
object as a source of experimental data for PyBOP.Motivation
PyProBE provides a user-friendly interface to experimental data allowing fast filtering to the subset of data of interest for further analysis.
The PyProBE README format would also provide value, closing the loop between the experimental and the PyBaMM Experiment that PyBOP uses for fitting.
Possible implementation
Utility function to import PyProBE objects into the required format, following discussion that ensures common syntax between PyProBE and PyBOP. The PyProBE object can provide both the filtered raw data and corresponding PyBaMM step instructions.
Corresponding example demonstrating this integration.
Additional context
No response
The text was updated successfully, but these errors were encountered: