Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser to import experimental data processed using PyProBE #515

Open
tomjholland opened this issue Sep 20, 2024 · 1 comment
Open

Add parser to import experimental data processed using PyProBE #515

tomjholland opened this issue Sep 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tomjholland
Copy link

Feature description

Add the capability to directly import a PyProBE Result object as a source of experimental data for PyBOP.

Motivation

PyProBE provides a user-friendly interface to experimental data allowing fast filtering to the subset of data of interest for further analysis.

The PyProBE README format would also provide value, closing the loop between the experimental and the PyBaMM Experiment that PyBOP uses for fitting.

Possible implementation

  1. Utility function to import PyProBE objects into the required format, following discussion that ensures common syntax between PyProBE and PyBOP. The PyProBE object can provide both the filtered raw data and corresponding PyBaMM step instructions.

  2. Corresponding example demonstrating this integration.

Additional context

No response

@tomjholland tomjholland added the enhancement New feature or request label Sep 20, 2024
@BradyPlanden
Copy link
Member

Hi Tom, thanks for opening this issue. PyProBE looks like an interesting package, we'd welcome a PR to flesh out the integration. Initially, I would recommend a notebook or script that can then be refactored to work within either the pybop.Dataset class or a utility method as you described. Nice job on the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants