Publishing fails if dist/ folder contains a subfolder

[ssbarnea]

I observed a bug in publishing, basically presence of folders inside dist/ breaks the publishing:

Checking dist/ansible_dev_tools-0.2.0a0-py3-none-any.whl: PASSED
Checking dist/ansible-dev-tools-0.2.0a0.tar.gz: PASSED
Checking dist/test: ERROR    InvalidDistribution: Unknown distribution format: 'test'

That happened because dist/test/ exists.

[woodruffw]

This is probably happening because of twine check: twine's assumption is that everything under dist/* is either an uploadable distribution or some kind of sidecar file that the index supports (historically, things like PGP .asc signatures).

ref: https://github.com/pypa/twine/blob/96674dbb359b0121b1d0aaa908c93dc11344c2f7/twine/package.py#L104-L106

TL;DR: This is twine's behavior, not this workflow's, so this issue might be better suited for them 🙂. But it's also (I believe) long-standing behavior, so they may not want to change it.

[woodruffw]

Just noticed that this workflow will skip twine check if verify-metadata: false is passed.

@ssbarnea can you see if that silences the error for you? I suspect that it might not, since twine upload will also perform the same check anyways.

[webknjaz]

FWIW, I'm not sure if I'd want to support this in the action. A folder with uploadables has always been the interface for feeding stuff into the action (short of the inputs). Besides, it's intentionally not doing many things, offloading everything possible to the underlying tools.

[webknjaz]

Duplicate of #148