You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to fix the API for 1.0 release. Unfortunately, there are going to be some breaking changes ;)
Here are some of them:
stream_stream client call (and maybe stream_unary) should really be an async context manager: there is implicit thread of execution running that's feeding the internal send buffer with data from async iterable. If the exception occurs when sending the data (e.g. server expects 3 messages, but client sends 4), this exception should not be discarded. This is in contrast to Google's official grpc implementation, which in the example above will silently discard the exception. I do not think this is reasonable.
Need to expose stream-like API for those, who does not need separate execution thread for stream_stream calls, this may break something, but I am not sure.
Maybe we should change generated files suffix from _grpc.py to something more self-describing, like _purerpc.py
Overall, I think the API should be as close as it can get to grpcio modulo the corner cases described above.
The text was updated successfully, but these errors were encountered:
We need to fix the API for 1.0 release. Unfortunately, there are going to be some breaking changes ;)
Here are some of them:
request
argument mandatorycontext
argument._grpc.py
to something more self-describing, like_purerpc.py
Overall, I think the API should be as close as it can get to grpcio modulo the corner cases described above.
The text was updated successfully, but these errors were encountered: