Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictConfig in misc/greeter is excessive #9

Open
ei-grad opened this issue Jan 25, 2019 · 1 comment
Open

dictConfig in misc/greeter is excessive #9

ei-grad opened this issue Jan 25, 2019 · 1 comment

Comments

@ei-grad
Copy link

ei-grad commented Jan 25, 2019

It doesn't make sense to have the copy-pasted verbose logging configuration in main.py, main_pingpong.py and main_pingpong_servicer.py, which has the effect equal to

logging.basicConfig(format="[%(asctime)s - %(name)s - %(levelname)s]:  %(message)s", level=logging.WARNING)
@standy66
Copy link
Member

standy66 commented Jan 25, 2019

I was kinda in a hurry when I did that, and just copy-pasted some leftover code from previous projects. Feel free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants