Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI changes #2885

Open
13 of 17 tasks
A5rocks opened this issue Nov 24, 2023 · 14 comments
Open
13 of 17 tasks

CI changes #2885

A5rocks opened this issue Nov 24, 2023 · 14 comments

Comments

@A5rocks
Copy link
Contributor

A5rocks commented Nov 24, 2023

Fixing existing runs:

Adding more runs:

Removing runs:

These feel like they will take more motivation than I currently have :(

@jakkdl
Copy link
Member

jakkdl commented Nov 24, 2023

A more fun change: Add python 3.13

@TeamSpen210
Copy link
Contributor

We also aren't running 3.11/3.12 on Windows.

@jakkdl
Copy link
Member

jakkdl commented Dec 16, 2023

@jakkdl
Copy link
Member

jakkdl commented Jan 7, 2024

Add back Alpine Linux for testing musl libc.
#2917

@jakkdl
Copy link
Member

jakkdl commented Jan 8, 2024

Sleep timing fail on MacOS pypy3.10 https://github.com/python-trio/trio/actions/runs/7448486091/job/20262980216?pr=2886

FAILED ../../../_temp/116e3acf-3f1d-45b1-afa8-48d74a477716/pypy-c-jit-184208-0c87577e022f-macos_x86_64/lib/pypy3.10/site-packages/trio/_tests/test_timeouts.py::test_sleep - assert (1.70860500699996 / 1.0) < 1.5

Not especially weird, and only problematic if it's encountered regularly.

@jakkdl
Copy link
Member

jakkdl commented Feb 6, 2024

Is it possible to trigger actions on "push or pull request" rather than "push and pull request"? I started #2942 on a branch in trio/ to be able to run tests w/o spamming a PR, but once I opened the PR I'm getting double runs.

@TeamSpen210
Copy link
Contributor

A few possible ways:

  • Using concurrency groups - create a group name including the commit hash, then it'd only allow one of the pair to run at a time. Then we'd set "cancel-in-progress" to true only on the PR run, causing the push to be cancelled. Downside is that the push events are still run and cancelled, wasting time and cluttering the runs list.
  • We could set the push event to only apply to master, so you'd need to open a PR to get CI. May not be helpful.
  • We could add a job to the workflow that runs before everything else on push requests. It'd fetch all PRs via the API, get their hash, figure out if we match and then skip the rest. Shouldn't be too complex?

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 7, 2024

I think the 3rd is the best solution. Just a gh pr view on push and if there's a PR then don't run the next steps. Maybe a if: in the actual CI workflows that checks input and otherwise skips?

The 1st isn't great cause it'll clutter notifications too

@jakkdl
Copy link
Member

jakkdl commented Feb 12, 2024

Edited list in OP to refer to #2776 and #2678 wrt to pypy+windows (and split up mac&windows at the same time)

@jakkdl
Copy link
Member

jakkdl commented May 24, 2024

A more fun change: Add python 3.13

with a first beta released this should probably be done sooner rather than later.

@jakkdl
Copy link
Member

jakkdl commented Dec 18, 2024

@jakkdl
Copy link
Member

jakkdl commented Dec 18, 2024

We should move test_static_tool_sees_all_symbols from the tests run on all platforms to our check.sh/"check formatting" run - it's often veery slow (20+ seconds for the worst matrix entry)

@A5rocks
Copy link
Contributor Author

A5rocks commented Dec 21, 2024

We should move test_static_tool_sees_all_symbols from the tests run on all platforms to our check.sh/"check formatting" run - it's often veery slow (20+ seconds for the worst matrix entry)

I agree. My first thought is maybe just use pytest -k? That should help.

@jakkdl
Copy link
Member

jakkdl commented Dec 21, 2024

We should move test_static_tool_sees_all_symbols from the tests run on all platforms to our check.sh/"check formatting" run - it's often veery slow (20+ seconds for the worst matrix entry)

I agree. My first thought is maybe just use pytest -k? That should help.

definitely not the prettiest solution to do pytest -k "not test_static_tool" in ci.sh and pytest -k test_static_tool in check.sh, but would be a quick fix that could be prettified later.

actually scratch that, let's just take all of src/trio/_tests/test_exports and move it somewhere like tests/static_tests/. _trio_check_attrs_aliases.py is there already anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants