Remove deprecated unbounded queue #2925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 124 122 -2
Lines 18427 18269 -158
Branches 1215 1205 -10
================================================
- Hits 18427 18269 -158
|
Also make the generation script always use unix newlines, even on Windows
CoolCat467
reviewed
Jan 16, 2024
Comment on lines
+27
to
+28
| # waitqueue), but in the future we ever start support task priorities or fair | ||
| # scheduling |
There was a problem hiding this comment.
The grammar here is a bit odd. I would change it to something like
"but in the future if we ever support task priorities or
fair scheduling it should be fairly simple."
A5rocks
commented
Jan 16, 2024
| @@ -43,7 +43,7 @@ def current_kqueue() -> select.kqueue: | |||
|
|
|||
| def monitor_kevent( | |||
| ident: int, filter: int | |||
| ) -> ContextManager[_core.UnboundedQueue[select.kevent]]: | |||
| ) -> ContextManager[MemoryReceiveChannel[select.kevent]]: | |||
There was a problem hiding this comment.
Huh actually I'm just realizing this is potentially a compat break. I can work around this using a kwarg but I need to see if this currently warns or not...
There was a problem hiding this comment.
Private subclass which adds the unbounded queue methods but warns if you call them?
graingert
force-pushed
the
eliminate-unbounded-queue
branch
from
ef73f38 to
009cbb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much based off of #937; fixes #2922; should be in the next 0.x.0 release so don't merge this yet!