Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download the appropriate WASI SDK for the CPU architecture #25

Open
brettcannon opened this issue Oct 19, 2024 · 1 comment
Open

Download the appropriate WASI SDK for the CPU architecture #25

brettcannon opened this issue Oct 19, 2024 · 1 comment

Comments

@brettcannon
Copy link
Member

Right now we download the x64 version unconditionally, but instead we should do it for the right CPU. I think it requires using TARGETPLATFORM and then doing an if in the RUN.
@brettcannon
Copy link
Member Author

Might be able to get away with just TARGETARCH since our containers are all Linux.

https://github.com/BretFisher/multi-platform-docker-build/blob/main/README.md
https://docs.docker.com/build/building/variables/#multi-platform-build-arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon