Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about "Server" checkbox in the plugin settings #487

Closed
Gustry opened this issue Nov 18, 2024 · 4 comments
Closed

Be more explicit about "Server" checkbox in the plugin settings #487

Gustry opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
🕔 Size 2 Give me 2 hours and I will have it for you

Comments

@Gustry
Copy link
Contributor

Gustry commented Nov 18, 2024

Given the page https://plugins.qgis.org/plugins/server/

image

I went to check a few plugins to look at their __init__.py file :

They only define a classFactory, while a QGIS server plugin must define serverClassFactory, see the docs

My guess, it's that when they upload a new plugin, they don't know much about this checkbox :
https://plugins.qgis.org/plugins/gazetteer_creator/update/

image

Maybe a string or tooltip adding some information would be welcome.

A server plugin is a plugin which can run on QGIS Server, by having a entrypoint serverClassFactory, see the documentation.

I'm not sure if it's quick to add a check when a version is uploaded.

@Gustry
Copy link
Contributor Author

Gustry commented Nov 18, 2024

I manually cleaned the list by editing the plugin settings.

@Xpirix Xpirix self-assigned this Nov 19, 2024
@Xpirix Xpirix added the 🕔 Size 2 Give me 2 hours and I will have it for you label Nov 19, 2024
@Xpirix Xpirix moved this to This sprint in QGIS Websites Maitenance Nov 19, 2024
@Xpirix
Copy link
Collaborator

Xpirix commented Nov 22, 2024

Hi @Gustry

Please find the proposed fix at #490. About the check, do you mean a blocking error that arises whenever the server attribute is set to True in the metadata, but the entry point serverClassFactory doesn't exist in init.py file?
If so, I think it would change the workflow of the plugin. Perhaps we should let others know before. What do you think?

@Gustry
Copy link
Contributor Author

Gustry commented Dec 3, 2024

Thanks @Xpirix for your fix.

I was jsut wondering the same question as in #494 if the flag in the metadata.txt should be prioritize versus the one in the plugin settings.

I'm not sure what is the workflow under the hood about this flag which can be set in two different places.

@Xpirix
Copy link
Collaborator

Xpirix commented Dec 4, 2024

You're welcome @Gustry.

Replied at #494 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Size 2 Give me 2 hours and I will have it for you
Projects
Development

No branches or pull requests

2 participants