{% if title %}{{title}}{% else %}{% trans "Invalid Plugins" %}{% endif %}
+ {# Filtered views menu #} + {% if object_list.count %} +
+ {% blocktrans with records_count=page_obj.paginator.count %}{{ records_count }} records found{% endblocktrans %} —
+ {% trans "Click to toggle descriptions." %}
+
+
+ {#% include 'sortable_listview/sort_links.html' %#}
+
+ | + | {% anchor name %} | +{% anchor author "Author" %} | +{% anchor validated_version "Validated Version" %} | +{% anchor validated_at "Validated at" %} | +{% anchor message "Error message" %} | +
|---|---|---|---|---|---|
|
+ {% if object.plugin.icon and object.plugin.icon.file %}
+ {% thumbnail object.icon "24x24" format="PNG" as im %}
+ |
+ {{ object.plugin.name }} | +{{ object.plugin.author }} | +{{ object.validated_version }} | +{{ object.validated_at }} | +{{ object.message }} | +
+ {% include 'sortable_listview/pagination.html' %}
+
+
+
+ {% trans "Deprecated plugins are printed in red." %}
+
+ {% else %}
+ {% block plugins_message %}
+
+
+ {% trans "This list is empty!" %}
+
+ {% endblock %}
+ {% endif %}
+
+{% endblock %}
diff --git a/qgis-app/plugins/tests/model_factories.py b/qgis-app/plugins/tests/model_factories.py
new file mode 100644
index 00000000..14ee2ca4
--- /dev/null
+++ b/qgis-app/plugins/tests/model_factories.py
@@ -0,0 +1,88 @@
+"""Factories for building model instances for testing."""
+
+import factory
+import os
+
+from django.contrib.auth.models import User
+from django.core.files.uploadedfile import InMemoryUploadedFile
+
+from plugins.models import Plugin, PluginVersion, PluginInvalid
+
+
+# TESTFILE_DIR = os.path.abspath(
+# os.path.join(os.path.dirname(__file__), 'testfiles'))
+#
+#
+# ZIPFILE = InMemoryUploadedFile(
+# os.path.join(TESTFILE_DIR, "valid_metadata_link.zip"),
+# field_name='tempfile',
+# name='testfile.zip',
+# content_type='application/zip',
+# size=39889,
+# charset='utf8')
+
+FAKE = factory.faker.faker.Faker()
+
+class UserF(factory.django.DjangoModelFactory):
+ """User model factory."""
+
+ class Meta:
+ model = User
+
+ username = factory.Sequence(lambda n: "username%s" % n)
+ first_name = FAKE.first_name()
+ last_name = FAKE.last_name()
+ email = FAKE.email()
+ password = ''
+ is_staff = False
+ is_active = True
+ is_superuser = False
+
+
+class PluginF(factory.django.DjangoModelFactory):
+ """Plugin model factory."""
+
+ class Meta:
+ model = Plugin
+
+ created_by = factory.SubFactory(UserF)
+ author = FAKE.name()
+ email = FAKE.email()
+ homepage = factory.Sequence(lambda n: "https://www.example-%s.com" % n)
+ repository = "https://github.com/qgis/QGIS-Django"
+ tracker = "https://github.com/qgis/QGIS-Django/issues"
+
+ # name, desc etc.
+ package_name = factory.Sequence(lambda n: "package_%s" % n)
+ name = factory.Sequence(lambda n: "name_%s" % n)
+ description = factory.Sequence(lambda n: "Description of name_%s" % n)
+ about = factory.Sequence(lambda n: "About name_%s" % n)
+
+ # downloads (soft trigger from versions)
+ downloads = factory.Sequence(lambda n: n)
+
+
+class PluginVersionF(factory.django.DjangoModelFactory):
+ """PluginVersion model factory."""
+
+ class Meta:
+ model = PluginVersion
+
+ # link to parent
+ plugin = factory.SubFactory(PluginF)
+ created_by = factory.SubFactory(UserF)
+ min_qg_version = "002.000.000"
+ max_qg_version = "002.099.003.###"
+ version = "1.2.3.4"
+ package = factory.django.FileField(filename='plugin.zip')
+
+
+class PluginInvalidF(factory.django.DjangoModelFactory):
+ """PluginVersion model factory."""
+
+ class Meta:
+ model = PluginInvalid
+
+ plugin = factory.SubFactory(PluginF)
+ validated_version = "0.0.0.0"
+ message = "File does not exist. Please re-upload."
diff --git a/qgis-app/plugins/tests/test_models.py b/qgis-app/plugins/tests/test_models.py
new file mode 100644
index 00000000..20dae7c1
--- /dev/null
+++ b/qgis-app/plugins/tests/test_models.py
@@ -0,0 +1,70 @@
+import os
+
+from django.contrib.auth.models import User
+from django.core.files.uploadedfile import InMemoryUploadedFile
+from django.test import TestCase, override_settings
+
+from plugins.models import PluginVersion, Plugin, PluginInvalid
+
+TESTFILE_DIR = os.path.abspath(
+ os.path.join(os.path.dirname(__file__), 'testfiles'))
+
+
+@override_settings(MEDIA_ROOT='plugins/tests/testfiles/')
+@override_settings(MEDIA_URL='plugins/tests/testfiles/')
+class TestPluginInvalidModel(TestCase):
+
+ def setUp(self) -> None:
+ self.creator = User.objects.create(
+ username='usertest_creator',
+ first_name="first_name",
+ last_name="last_name",
+ email="creator@example.com",
+ password="passwordtest",
+ is_active=True)
+ self.author = User.objects.create(
+ username='usertest_author',
+ first_name="author",
+ last_name="last_name",
+ email="author@example.com",
+ password="passwordtest",
+ is_active=True)
+
+ invalid_plugin = os.path.join(
+ TESTFILE_DIR, "web_not_exist.zip")
+ self.invalid_plugin = open(invalid_plugin, 'rb')
+
+ uploaded_zipfile = InMemoryUploadedFile(
+ self.invalid_plugin,
+ field_name='tempfile',
+ name='testfile.zip',
+ content_type='application/zip',
+ size=39889,
+ charset='utf8')
+
+ self.plugin = Plugin.objects.create(
+ created_by=self.creator,
+ name='test_plugin',
+ package_name='test_plugin'
+ )
+
+ self.version = PluginVersion.objects.create(
+ plugin=self.plugin,
+ created_by=self.creator,
+ version='0.1',
+ package=uploaded_zipfile,
+ min_qg_version='3.10',
+ max_qg_version='3.18'
+ )
+
+ def tearDown(self) -> None:
+ self.invalid_plugin.close()
+ os.remove(self.version.package.url)
+
+ def test_create_PluginInvalid_instance(self):
+ invalid_plugin = PluginInvalid.objects.create(
+ plugin=self.plugin,
+ validated_version=self.plugin.pluginversion_set.get().version
+ )
+ self.assertEqual(invalid_plugin.validated_version, '0.1')
+ self.assertIsNotNone(invalid_plugin.validated_at)
diff --git a/qgis-app/plugins/tests/test_validate_existing_plugins.py b/qgis-app/plugins/tests/test_validate_existing_plugins.py
new file mode 100644
index 00000000..1dd9c849
--- /dev/null
+++ b/qgis-app/plugins/tests/test_validate_existing_plugins.py
@@ -0,0 +1,118 @@
+import os
+
+from django.contrib.auth.models import User
+from django.core import mail
+from django.core.files.uploadedfile import InMemoryUploadedFile
+from django.test import TestCase, override_settings
+
+from plugins.models import PluginVersion, Plugin, PluginInvalid
+from plugins.management.commands.validate_existing_plugins import (
+ validate_zipfile_version, send_email_notification)
+
+TESTFILE_DIR = os.path.abspath(
+ os.path.join(os.path.dirname(__file__), 'testfiles'))
+
+
+@override_settings(MEDIA_ROOT='plugins/tests/testfiles/')
+@override_settings(MEDIA_URL='plugins/tests/testfiles/')
+class TestValidateExistingPlugin(TestCase):
+
+ def setUp(self) -> None:
+ self.creator = User.objects.create(
+ username='usertest_creator',
+ first_name="first_name",
+ last_name="last_name",
+ email="creator@example.com",
+ password="passwordtest",
+ is_active=True)
+ self.author = User.objects.create(
+ username='usertest_author',
+ first_name="author",
+ last_name="last_name",
+ email="author@example.com",
+ password="passwordtest",
+ is_active=True)
+
+ invalid_plugin = os.path.join(
+ TESTFILE_DIR, "web_not_exist.zip")
+ self.invalid_plugin = open(invalid_plugin, 'rb')
+
+ uploaded_zipfile = InMemoryUploadedFile(
+ self.invalid_plugin,
+ field_name='tempfile',
+ name='testfile.zip',
+ content_type='application/zip',
+ size=39889,
+ charset='utf8')
+
+ self.plugin = Plugin.objects.create(
+ created_by=self.creator,
+ name='test_plugin',
+ package_name='test_plugin'
+ )
+
+ self.version = PluginVersion.objects.create(
+ plugin=self.plugin,
+ created_by=self.creator,
+ version='0.1',
+ package=uploaded_zipfile,
+ min_qg_version='3.10',
+ max_qg_version='3.18'
+ )
+
+ def tearDown(self) -> None:
+ self.invalid_plugin.close()
+ os.remove(self.version.package.url)
+
+ def test_plugin_exist(self):
+ self.assertEqual(PluginVersion.objects.count(), 1)
+ self.assertTrue(os.path.exists(self.version.package.url))
+
+ def test_validate_zipfile_version(self):
+ expected_value = {
+ 'plugin': 'test_plugin',
+ 'created_by': 'usertest_creator',
+ 'version': '0.1',
+ 'version_id': self.version.id,
+ 'msg': ['Please provide valid url link for Repository in metadata. '
+ 'This website cannot be reached.'],
+ 'url': 'http://plugins.qgis.org/plugins/test_plugin/version/0.1/',
+ 'recipients_email': ['creator@example.com']}
+ self.assertEqual(
+ validate_zipfile_version(self.version),
+ expected_value,
+ msg=validate_zipfile_version(self.version)
+ )
+
+ @override_settings(
+ EMAIL_BACKEND='django.core.mail.backends.console.EmailBackend')
+ def test_send_email(self):
+ error_msg = validate_zipfile_version(self.version)
+ send_email_notification(
+ plugin=error_msg['plugin'],
+ version=error_msg['version'],
+ message='\r\n'.join(error_msg['msg']),
+ url_version=error_msg['url'],
+ recipients=error_msg['recipients_email']
+ )
+
+ def test_send_email_must_contains(self):
+ error_msg = validate_zipfile_version(self.version)
+ send_email_notification(
+ plugin=error_msg['plugin'],
+ version=error_msg['version'],
+ message='\r\n'.join(error_msg['msg']),
+ url_version=error_msg['url'],
+ recipients=error_msg['recipients_email']
+ )
+ self.assertEqual(len(mail.outbox), 1)
+ self.assertEqual(
+ mail.outbox[0].subject,
+ 'Invalid Plugin Metadata Notification')
+ self.assertIn(
+ 'Please update Plugin: test_plugin - Version: 0.1',
+ mail.outbox[0].body)
+ self.assertIn(
+ 'Please provide valid url link for Repository in metadata. '
+ 'This website cannot be reached.',
+ mail.outbox[0].body)
diff --git a/qgis-app/plugins/tests/test_views.py b/qgis-app/plugins/tests/test_views.py
new file mode 100644
index 00000000..3478b207
--- /dev/null
+++ b/qgis-app/plugins/tests/test_views.py
@@ -0,0 +1,151 @@
+import os
+import tempfile
+
+from django.core.files.uploadedfile import InMemoryUploadedFile
+from django.test import TestCase, override_settings
+from django.urls import reverse
+
+from plugins.models import PluginInvalid
+from plugins.tests.model_factories import (UserF,
+ PluginF,
+ PluginVersionF,
+ PluginInvalidF)
+
+
+TESTFILE_DIR = os.path.abspath(
+ os.path.join(os.path.dirname(__file__), 'testfiles'))
+
+
+@override_settings(MEDIA_ROOT=tempfile.mkdtemp())
+class TestInvalidPluginView(TestCase):
+ """Test InvalidPlugin View"""
+
+ # simplemenu will be loaded on base template. We need create its model
+ fixtures = ['fixtures/simplemenu.json']
+
+ def setUp(self) -> None:
+ self.user = UserF.create()
+ self.user.set_password('password')
+ self.user.is_staff = True
+ self.user.is_superuser = True
+ self.user.save()
+
+ valid_plugins = os.path.join(
+ TESTFILE_DIR, "valid_metadata_link.zip")
+ invalid_plugins = os.path.join(
+ TESTFILE_DIR, "invalid_metadata_link.zip")
+ self.valid_metadata_link = open(valid_plugins, 'rb')
+ self.invalid_metadata_link = open(invalid_plugins, 'rb')
+
+ self.plugin = PluginF.create(
+ package_name="test_plugin"
+ )
+
+ # Create invalid plugins
+ PluginInvalid.objects.all().delete()
+ self.plugin_version_1 = PluginVersionF.create(
+ version='0.0.0.0'
+ )
+ self.plugin_version_1.plugin.package_name = "test_modul"
+ self.plugin_version_1.plugin.save()
+ self.invalid_plugin_1 = PluginInvalidF.build(
+ plugin=self.plugin_version_1.plugin)
+ self.invalid_plugin_1.save()
+ self.plugin_version_2 = PluginVersionF.create()
+ self.invalid_plugin_2 = PluginInvalidF.build(
+ plugin=self.plugin_version_2.plugin)
+ self.invalid_plugin_2.save()
+
+ def tearDown(self):
+ self.valid_metadata_link.close()
+ self.invalid_metadata_link.close()
+
+ def test_PluginInvalid_list_should_return_invalid_plugin(self):
+ self.assertEqual(PluginInvalid.objects.count(), 2)
+ response = self.client.get(reverse('invalid_plugins'))
+ self.assertEqual(response.status_code, 200)
+ self.assertContains(response, self.invalid_plugin_1.plugin.name)
+ self.assertContains(response, self.invalid_plugin_2.plugin.name)
+ self.assertNotContains(response, self.plugin.name)
+
+ def test_update_plugin_should_remove_from_invalid_list(self):
+ self.assertEqual(PluginInvalid.objects.count(), 2)
+ url = reverse(
+ 'version_update',
+ kwargs={
+ "package_name": self.invalid_plugin_1.plugin.package_name,
+ "version": self.invalid_plugin_1.validated_version
+ })
+ data = {
+ "package": InMemoryUploadedFile(
+ self.valid_metadata_link,
+ field_name='tempfile',
+ name='testfile.zip',
+ content_type='application/zip',
+ size=39889,
+ charset='utf8'
+ )
+ }
+ self.client.login(username=self.user.username, password="password")
+ response = self.client.post(url, data, follow=True)
+ self.assertEqual(response.status_code, 200)
+ # The updated plugin should be removed from the invalid list
+ self.assertEqual(PluginInvalid.objects.count(), 1)
+
+ def test_update_plugin_should_remove_from_invalid_list(self):
+ self.assertEqual(PluginInvalid.objects.count(), 2)
+ url = reverse(
+ 'version_update',
+ kwargs={
+ "package_name": self.invalid_plugin_1.plugin.package_name,
+ "version": self.invalid_plugin_1.validated_version
+ })
+ data = {
+ "package": InMemoryUploadedFile(
+ self.valid_metadata_link,
+ field_name='tempfile',
+ name='testfile.zip',
+ content_type='application/zip',
+ size=39889,
+ charset='utf8'
+ )
+ }
+ self.client.login(username=self.user.username, password="password")
+ response = self.client.post(url, data, follow=True)
+ self.assertEqual(response.status_code, 200)
+ # The updated plugin should be removed from the invalid list
+ self.assertEqual(PluginInvalid.objects.count(), 1)
+ self.assertFalse(
+ PluginInvalid.objects.filter(
+ plugin__package_name=self.invalid_plugin_1.plugin.package_name
+ ).exists()
+ )
+
+ def test_create_new_version_should_remove_plugin_from_invalid_list(self):
+ self.assertEqual(PluginInvalid.objects.count(), 2)
+ url = reverse(
+ 'version_create',
+ kwargs={
+ "package_name": "test_modul"
+ })
+ data = {
+ "package": InMemoryUploadedFile(
+ self.valid_metadata_link,
+ field_name='tempfile',
+ name='testfile.zip',
+ content_type='application/zip',
+ size=39889,
+ charset='utf8'
+ )
+ }
+ self.client.login(username=self.user.username, password="password")
+ response = self.client.post(url, data, follow=True)
+ self.assertEqual(response.status_code, 200)
+ # The updated plugin should be removed from the invalid list
+ self.assertEqual(PluginInvalid.objects.count(), 1)
+ self.assertFalse(
+ PluginInvalid.objects.filter(
+ plugin__package_name="test_modul"
+ ).exists()
+ )
+
diff --git a/qgis-app/plugins/urls.py b/qgis-app/plugins/urls.py
index 6d0e35bc..e2ade5ab 100644
--- a/qgis-app/plugins/urls.py
+++ b/qgis-app/plugins/urls.py
@@ -55,6 +55,11 @@
url(r'^user/(?P