-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests, docs, build #266
base: master
Are you sure you want to change the base?
Conversation
If I may add one remark right away, I'm a bit skeptical about comments just for the sake of writing a comment but which don't add any real information. In my view they just make the code more cluttered and ultimately less readable. |
Thanks for the feed-back. Do you have specific examples? Most of the commetns are written so that they show up in the documentation. I'm in the habbit of interseeding comments before every few lines of code because I find it easier to understand said code a few month after. Especially so with JS. Python is easier on the eyes. My personal experience with open source projects is that the contributors are more likely to contribute if the code is well commented. That being said I admit that the main reason for writing the comments in code was to give me time to absorb the concepts and to form a mental map of the code. |
Is this the intendend behaviour? Only show the notification if the visibility of a different layer is set. See the test here: |
This is just a preview to get the discution started.
I has to upgrade
ol
andol-ext
to be able to runjest
.