Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation example in the documentation doesn't get fully simplified #89

Open
david-pl opened this issue Dec 5, 2021 · 0 comments

Comments

@david-pl
Copy link
Member

david-pl commented Dec 5, 2021

Currently, the example in the documentation show-casing the implementation of position and momentum operators produces equations that aren't fully simplified:

image

This is probably due to the Div type introduced in SymbolicUtils. We may need to call out to different simplification routines, e.g. simplify_fractions when simplifying in the meanfield function. I couldn't find any recommendation in the docs on how to best simplify fractions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant