httptransport: fix test flake #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
reviewed
Apr 9, 2024
| res, err := c.Get(u) | ||
| if err != nil { | ||
| t.Error(err) | ||
| // Create a scope for do the actual requests. |
There was a problem hiding this comment.
nit: comment
Suggested change
| // Create a scope for do the actual requests. | |
| // Create a scope for doing the actual requests. |
crozzy
approved these changes
Apr 10, 2024
Saw this test flake in CI and managed to reproduce locally. I haven't been able to reproduce with this patch, but don't have a great explanation as to why it's not consistent. Signed-off-by: Hank Donnay <[email protected]>
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this test flake in CI and managed to reproduce locally. I haven't been able to reproduce with this patch, but don't have a great explanation as to why it's not consistent.