Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move quickfixj-examples to separate repository #610

Open
chrjohn opened this issue Feb 8, 2023 · 5 comments
Open

Move quickfixj-examples to separate repository #610

chrjohn opened this issue Feb 8, 2023 · 5 comments
Assignees

Comments

@chrjohn
Copy link
Member

chrjohn commented Feb 8, 2023

@david-gibbs-ig
What do you think about the version numbering when separating the example? Should it start with 1.0.0?

@chrjohn chrjohn self-assigned this Feb 8, 2023
@david-gibbs-ig
Copy link
Contributor

Yes I think that will be fine, its dependency on QFJ version or versions will be explicit and I think it can be decoupled from the QFJ version. For example you may not want to have to re-release it all for each minor release of QFJ.

@david-gibbs-ig
Copy link
Contributor

david-gibbs-ig commented Feb 8, 2023

It seems that it's possible to keep the (pruned) history of the existing examples. Probably you know this but I have never done it :-)
https://amandawalkerbrubaker.medium.com/splitting-your-git-repo-while-maintaining-commit-history-35b9f4597514

There are changes to the examples for FIX Latest so it would be good to keep them if we can.

@chrjohn chrjohn changed the title Move examples to separate repository Move quickfixj-examples to separate repository Feb 9, 2023
@chrjohn
Copy link
Member Author

chrjohn commented Feb 9, 2023

@david-gibbs-ig thanks for the link. 👍 I didn't know it but I wanted to find out if that is possible since it would be good to keep the commit history.

@chrjohn
Copy link
Member Author

chrjohn commented Feb 20, 2023

@david-gibbs-ig
But I think that I need to increase the version number to the next major number (i.e. 3.0.0), otherwise it will probably cause problems when it's released under the same groupId and artifactId.

https://mvnrepository.com/artifact/org.quickfixj/quickfixj-examples-banzai

Do you agree? Changing the artifactId to something different might be unexpected.

@david-gibbs-ig
Copy link
Contributor

@david-gibbs-ig But I think that I need to increase the version number to the next major number (i.e. 3.0.0), otherwise it will probably cause problems when it's released under the same groupId and artifactId.

https://mvnrepository.com/artifact/org.quickfixj/quickfixj-examples-banzai

Do you agree? Changing the artifactId to something different might be unexpected.

Yes I see what you mean. Well 3.0.0 is fine then and should match peoples' expectations, after this it can be versioned independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants