-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborate with ciborium #3
Comments
Of course, how do you hope to collaborate? |
No idea. But I'd rather have one really good CBOR stack than multiple incomplete ones. Was there some defect or design considerations in ciborium that lead to an alternate implementation? |
There are two missing things in ciborium that prompted me to develop this crate
|
We have expressly supported exposing these. But nobody has stepped up to finish it. Would you like to?
We'd love to have this feature. Although one should note that not all CBOR wire values can be zero-copy decoded. Would you be willing to contribute these features to ciborium? |
I'm not sure how easy this is. when I tried to make ciborium support zero copy decode, I realized that it needed to be changed quite a bit. considering communication costs, I choose to implement my own library. |
@quininer If this is the biggest blocker, I'm happy to help you implement it. |
Looking at these benchmarks, it seems like cbor4ii turned out to be over 6x faster on average for serialization, and 2.5x faster for deserialization compared to ciborium. These numbers are pretty substantial, I'm happy there's different alternatives in the ecosystem for some to provide better performance/benefits over others, and without cbor4ii, we'd only have ciborium which is much slower sadly. |
https://github.com/enarx/ciborium/
Can we collaborate rather than building multiple CBOR stacks?
The text was updated successfully, but these errors were encountered: