From 73f8120b63b38f250ba231eaeebf1fda4f7a50af Mon Sep 17 00:00:00 2001 From: Umair Idris Date: Fri, 20 Jan 2017 11:07:09 -0800 Subject: [PATCH] Fixes #595, #601 Add translations for settings in sidebar (#602) * Add translations for settings in sidebar * new line * More translations * Periods * Rename settings ids * Use existing ids which I blindly missed * Delete ids from ur.js * Delete ids from en.js * Fix reciters title for ur/ar * Use setting.title * I should get some sleep * Revert setting.title to nav.settings * Remove setting.option, add nav.title --- src/components/Footer/index.js | 11 +++-------- src/components/GlobalSidebar/index.js | 5 +++-- src/components/SettingsModal/index.js | 15 +++++++++++---- src/locale/ar.js | 6 ++++-- src/locale/en.js | 8 +++++--- src/locale/ur.js | 6 ++++-- 6 files changed, 30 insertions(+), 21 deletions(-) diff --git a/src/components/Footer/index.js b/src/components/Footer/index.js index adb461302..f5e8c5a3c 100644 --- a/src/components/Footer/index.js +++ b/src/components/Footer/index.js @@ -135,13 +135,6 @@ const Footer = () => ( -

- -

-

( />

-

© QURAN.COM. ALL RIGHTS RESERVED 2016

+

+ © 2016 Quran.com. . +

diff --git a/src/components/GlobalSidebar/index.js b/src/components/GlobalSidebar/index.js index ef3f474fe..bf54e9538 100644 --- a/src/components/GlobalSidebar/index.js +++ b/src/components/GlobalSidebar/index.js @@ -56,7 +56,7 @@ class GlobalSidebar extends Component { className="navbar-text" onClick={() => handleOpen(false)} > - +

@@ -64,7 +64,8 @@ class GlobalSidebar extends Component { {children}
  • this.setState({ settingsModalOpen: true }, handleOpen(false))}> - {' '}Settings + {' '} +
  • diff --git a/src/components/SettingsModal/index.js b/src/components/SettingsModal/index.js index b42242e62..2c46faca4 100644 --- a/src/components/SettingsModal/index.js +++ b/src/components/SettingsModal/index.js @@ -2,6 +2,7 @@ import React, { PropTypes } from 'react'; import { connect } from 'react-redux'; import Modal from 'react-bootstrap/lib/Modal'; +import LocaleFormattedMessage from 'components/LocaleFormattedMessage'; import ReciterDropdown from 'components/ReciterDropdown'; import ContentDropdown from 'components/ContentDropdown'; import TooltipDropdown from 'components/TooltipDropdown'; @@ -37,26 +38,32 @@ const SettingsModal = ({ - Settings +
    -
    Reciters
    +
    + +
    -
    Translations
    +
    + +
    -
    Tooltip Content
    +
    + +