-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring 4.2.0 crashing when running rake #716
Comments
Also running into this issue on MacOS. This happens to me when the The next client to connect to the server will trigger that error, killing the server process and any live pre-existing client and will make the new client hang indefinitely on This is very frustrating when working on a git project, cause every change of branch is likely to trigger a watcher, which breaks the spring server and kills any open session (eg: a rails console being used, open a new terminal to run a I've been running into that issue for months now, it would be great if it could get fixed. Relates to #396, #663, looks like this issue is very resilient |
@fschwahn @fmichaut-diff I have a fix/workaround for this in #727 You could try it out to see if it fixes your issue, I have done so by using bundle open and applied the patch in the pr, as spring doesn't support being run as Would love to hear if it works with your version of rails, ruby, os, etc. |
Or as noted in CONTRIBUTING.md you can use |
I was able to reproduce reliably using your steps, and after applying your patch it no longer happens. I will now run this patch locally. |
Thanks @fschwahn. If you have a moment to list the versions of your OS, ruby and rails that would be helpful. I'm interested to know if the fix works for more than just for my versions. |
OS: macOS 14.6.1 |
I have been testing since yesterday, and things are looking good so far ! Thanks OS: MacOS 14.6.1 |
I actually managed to make spring work with so here is how my #!/usr/bin/env ruby
# This file loads Spring without loading other gems in the Gemfile in order to be fast.
# It gets overwritten when you run the `spring binstub` command.
if !defined?(Spring) && [nil, '', "development", "test"].include?(ENV["RAILS_ENV"])
require "bundler/setup"
require "spring/binstub"
end this simply makes it work. the reason it does not work with Bundler.locked_gems.specs.find { |spec| spec.name == "spring" }&.tap do |spring|
Gem.use_paths Gem.dir, Bundler.bundle_path.to_s, *Gem.path but when I realized i don't need them to make spring work, I simply removed them. Hopefully this can help people use forked versions of spring in their projects. I just merged 3 of the PRs you guys did in my own fork, and it works flawlessly. and it's ready for ruby 3.4.0 release 👌🏼 |
This happened to me when running
rails db:migrate
.I have never seen this before, and I have been using spring daily for years. Maybe it is connected to the changes in 4.2.0 (namely #708).
I'm running spring server as a separate process, so I have logs / stacktrace to share:
The text was updated successfully, but these errors were encountered: