Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include 0.x updates in --target minor #1427

Open
1 task done
danwdart opened this issue Jul 2, 2024 · 1 comment
Open
1 task done

Don't include 0.x updates in --target minor #1427

danwdart opened this issue Jul 2, 2024 · 1 comment

Comments

@danwdart
Copy link

danwdart commented Jul 2, 2024

  • I have searched for similar issues
    (sorry if I missed it, tried to look for 0.)

I don't think we should include 0.x updates in --target minor. It's not quite the same as --target semver because if the user specified bounds of only 0.x.y and not 0.x.z, --target minor should update to 0.x.z anyway, and not to e.g. 0.w.0.


Steps to Reproduce

  1. Have a package.json pointing to e.g. axios 0.18.x
  2. Run ncu --target minor.
  3. Observe that axios has been updated despite semver stating here that 0.x is inherently unstable and that changing x in 0.x.y is not necessarily a minor change, only after v1.

Current Behavior

0.x versions are updated using --target minor.

Expected Behavior

0.x versions to be left alone using --target minor.

Thanks!

@raineorshine
Copy link
Owner

raineorshine commented Jul 2, 2024

Previous discussions in #958 and #1213.

After having a couple of these discussions, I've ended up here:

  • I'm not comfortable with --target minor including v0.x, as it leads to confusion.
  • I'm not comfortable with --target minor excluding v0.x, as it is too close to --target semver and will lead to a different kind of confusion.

So my tendency is to leave things as they are, since I'm not really satisfied with either behavior. I'm also leaning towards leaving things as they are since there are several workarounds:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants