Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Some Features #567

Open
nvandendries1984 opened this issue Sep 8, 2024 · 4 comments
Open

Missing Some Features #567

nvandendries1984 opened this issue Sep 8, 2024 · 4 comments

Comments

@nvandendries1984
Copy link

I miss the following features:

  1. When a user registers, I would like the activation to be done by email and/or by the administrator.
    At the moment, when a user registers, it is automatically activated. I would like activation to occur only after confirming the email address.
  2. Excluding email addresses based on domain name.

I have been looking but can't find it. It would be nice if this features could be added to the backend settings model.

@chrisvidal
Copy link
Contributor

the activation email option was there in the previous version of the plugin - not sure what happened -

another features I'd like to see is sending an activation email with a 6 digit code for example, that we could use in different instance inside an developed application

@Veroboy
Copy link

Veroboy commented Nov 26, 2024

As I understand it, a confirmation email should be sent automatically after registration, but this does not happen. And I remember that earlier in the plugin settings, it was possible to configure how registration would take place, 1 - immediately activated, 2 - By email and 3 - manually by the administrator. There are no such settings anymore.
I tried to override the onRegister() function, and added $user->sendEmailConfirmationNotification(); but still the email is not sent to the mail.
And it is not clear how you can force notifications to be sent with an activation code.

@chrisvidal
Copy link
Contributor

it seems that some previous existing features have been parked.
I found a trait HasLegacyApi that provide the old user registration logic in there. Maybe that could help

@chrisvidal
Copy link
Contributor

I did some digging around and you can actually do check the user email.
The logic is now different. The user can register and access its account data even if its email is not yet verified.
You can test all that logic using the Vanilla theme.
in the theme, you can register and see your profile account, in there you can see a button verify my email which run the ajax method onVerifyEmail() from the account component

`/**
* onVerifyEmail sends the verification email to the user
*/
public function onVerifyEmail()
{
$this->actionVerifyEmail();

    if ($flash = Cms::flashFromPost(__("Please check your email for instructions."))) {
        Flash::success($flash);
    }

    $this->page['showLinkSent'] = true;
}`

based on that we can do it on our own logic, catching the user/register event, send this verification email and give access to his account only when the email is verified, if we want to mimic the previous plugin v2 behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants