Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add a callback parameter to stop() #10

Open
silentstormm opened this issue Feb 27, 2020 · 1 comment
Open

[Improvement] Add a callback parameter to stop() #10

silentstormm opened this issue Feb 27, 2020 · 1 comment

Comments

@silentstormm
Copy link

Would it be possible to add a callback parameter to stop which would fire once the connection stops?

@silentstormm silentstormm changed the title Add a callback parameter to stop() [Improvement] Add a callback parameter to stop() Feb 27, 2020
@rakusan2
Copy link
Owner

Adding this is easy but first I would like to know your opinion on the following.
If .destroy() is called after .stop() but before the socket closes, should the callback still be called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants