-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add narwhals tests to our test suite #17662
Comments
Thanks for the ping! Glad to hear our test suite has been useful You can run the Narwhals test suite in ~60-70 seconds: https://www.kaggle.com/code/marcogorelli/testing-cudf-in-narwhals?scriptVersionId=215469980
So long as cuDF is installed, it will include cuDF in the parametrised tests |
Awesome. From a quick look at the configuration it looks like the test suite automatically selects which narwhals backends to test. Is there a way to select some explicitly? If not, would you be open to adding some custom flags to your |
Definitely in-scope, we'll look into how to provide this |
Alright, done! Here's an example of how you could run the tests: https://www.kaggle.com/code/marcogorelli/testing-cudf-in-narwhals?scriptVersionId=216065554
|
Is your feature request related to a problem? Please describe.
@MarcoGorelli has reported a number of issues to cudf stemming from narwhals. narwhals is sussing out a number of issues that we don't currently see anywhere else except likely in the pandas test suite, where our pass rate remains too low to be used as an absolute pass/fail indicator in CI.
Describe the solution you'd like
We would benefit from running the narwhals test suite as part of cudf's CI similarly to how we run the pandas test suite.
Describe alternatives you've considered
None
Additional context
The narwhals tests look like they take <5 min, so they shouldn't be too expensive, but I would still recommend only running them on a single CUDA ver/Python ver/arch combination to limit resource usage.
The text was updated successfully, but these errors were encountered: