Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs aren't statically checked when using .get(…), .post(…), etc #5

Open
wolever opened this issue Apr 12, 2018 · 0 comments
Open

Comments

@wolever
Copy link

wolever commented Apr 12, 2018

Because the definitions of get(…), post(…), etc use Path | string, invalid paths aren't checked:

So, for example, this will compile without issue:

interface MyAPI {
  '/foo': {}
}

let api = axios.create<MyAPI>()
api.get('/bar') // <-- compiles

I realize that this is necessary to support paths with query parameters… but it should really be noted in the documentation, because it's pretty surprising :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant