[Data] optimize dataset.unique() #49296
Open
+118
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current implementation uses
groupby(column).count()
that causes a full sort. The new implementation usesAggregateFn
which usesgroupby(None)
andset()
to aggregate unique values.The time complexity should be O(N / parallelism) according to
ds.aggregate()
.It's about 10x faster in my local test.
Some part of
test_unique
is removed because it was designed for the original implementation.Related issue number
Closes #49298
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.