From cfbd76292f1b0bf1c68d601fbe73e0da7b9eb528 Mon Sep 17 00:00:00 2001 From: miguelgfierro Date: Mon, 23 Dec 2024 16:50:01 +0100 Subject: [PATCH 1/2] Add tag to federeated credential Signed-off-by: miguelgfierro --- tests/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/README.md b/tests/README.md index cb938c427..064c107ab 100644 --- a/tests/README.md +++ b/tests/README.md @@ -250,8 +250,7 @@ Then, follow the steps below to create the AzureML infrastructure: * AzureML Compute Operator * AzureML Data Scientist * Reader - 1. [Create a federated identiy credential on the - UMI](https://learn.microsoft.com/en-us/entra/workload-id/workload-identity-federation-create-trust-user-assigned-managed-identity?pivots=identity-wif-mi-methods-azp#github-actions-deploying-azure-resources) + 1. [Create a federated identity credential on the UMI](https://learn.microsoft.com/en-us/entra/workload-id/workload-identity-federation-create-trust-user-assigned-managed-identity?pivots=identity-wif-mi-methods-azp#github-actions-deploying-azure-resources) with the following settings: * Name: A unique name for the federated identity credential within your application. @@ -262,6 +261,7 @@ Then, follow the steps below to create the AzureML infrastructure: + `repo:recommenders-team/recommenders:pull_request` + `repo:recommenders-team/recommenders:ref:refs/heads/staging` + `repo:recommenders-team/recommenders:ref:refs/heads/main` + + `repo:recommenders-team/recommenders:ref:refs/tags/1.2.1` * Description: (Optional) A description of the credential. * Audiences: Specifies who can use this credential; for GitHub Actions, use `api://AzureADTokenExchange`. From f510ec4f603329fad9a0df12c64f0ac16fc0fd73 Mon Sep 17 00:00:00 2001 From: miguelgfierro Date: Mon, 23 Dec 2024 16:51:26 +0100 Subject: [PATCH 2/2] Note in setup Signed-off-by: miguelgfierro --- SETUP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SETUP.md b/SETUP.md index 4593b4cfb..0072f77c1 100644 --- a/SETUP.md +++ b/SETUP.md @@ -247,7 +247,7 @@ First make sure that the tag that you want to add, e.g. `0.6.0`, is added in [`r 1. Make sure that the code in main passes all the tests (unit and nightly tests). 1. Create a tag with the version number: e.g. `git tag -a 0.6.0 -m "Recommenders 0.6.0"`. 1. Push the tag to the remote server: `git push origin 0.6.0`. -1. When the new tag is pushed, a release pipeline is executed. This pipeline runs all the tests again (PR gate and nightly builds), generates a wheel and a tar.gz which are uploaded to a [GitHub draft release](https://github.com/microsoft/recommenders/releases). +1. When the new tag is pushed, a release pipeline is executed. This pipeline runs all the tests again (PR gate and nightly builds), generates a wheel and a tar.gz which are uploaded to a [GitHub draft release](https://github.com/microsoft/recommenders/releases). *NOTE: Make sure you add the release tag to the [federeted credendials](tests/README.md).* 1. Fill up the draft release with all the recent changes in the code. 1. Download the wheel and tar.gz locally, these files shouldn't have any bug, since they passed all the tests. 1. Install twine: `pip install twine`