Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aabb2d Struct API missing diag and sizev functions from Array API #429

Open
rogeriodomingos opened this issue Sep 3, 2024 · 3 comments
Open

Comments

@rogeriodomingos
Copy link

The aabb2d Struct API has glms_aabb2d_size which should probably be renamed to glms_aabb2d_diag and call glm_aabb2d_diag from the Array API. It is also missing glms_aabb2d_sizev which should call glm_aabb2d_sizev.

@recp
Copy link
Owner

recp commented Sep 5, 2024

Hi @rogeriodomingos,

Thanks for the catch! I’ll do it asap if no one intends to create a PR :)

@duarm
Copy link
Contributor

duarm commented Sep 20, 2024

I might pick this one up this weekend, it's my fault anyway

@recp
Copy link
Owner

recp commented Sep 22, 2024

Hi @duarm,

Sounds great, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants