Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Move react-router v3 to separate package #4971

Closed
chrisblossom opened this issue Apr 14, 2017 · 6 comments
Closed

Idea: Move react-router v3 to separate package #4971

chrisblossom opened this issue Apr 14, 2017 · 6 comments

Comments

@chrisblossom
Copy link

Now that react-router v4 is out and since v3 is still being maintained, it would be very helpful to split react-router v3 into its own repo / npm package.

This will help with sorting through issues, and running npm outdated / yarn upgrade-interactive to show v3 instead of v4- not having to manually check for v3 releases.

Sorry if this has already been discussed, I could not find anything.

@chrisblossom chrisblossom changed the title Move react-router v3 to separate package Idea: Move react-router v3 to separate package Apr 14, 2017
@timdorr
Copy link
Member

timdorr commented Apr 14, 2017

If we need to break semver, I'm squatting on react-router-dom. But so far the plan is to keep things in the same place. We're really only doing bug fixes on 3.0. If you want to do some major changes, a fork is the best option there.

@timdorr timdorr closed this as completed Apr 14, 2017
@evan-scott-zocdoc
Copy link

@timdorr Does all the new prop-types stuff count as a bugfix? I distinctly remember someone on the RR team saying 3.x will be maintained indefinitely, which I would hope would include important changes like that.

@evan-scott-zocdoc
Copy link

@timdorr nvm just noticed the 3.x branch!

@chrisblossom
Copy link
Author

@timdorr little off the scope of this, but can you recommend a way to see any updates to react-router v3 via npm/yarn? Especially for those of us that pin package versions. This is the biggest reason I'd like to see v3 split to its own package.

@timdorr
Copy link
Member

timdorr commented Apr 17, 2017

If you pin to ^3.0.0, then npm upgrade will get them. I've also been publishing them with the previous tag. You can see them all in npm show react-router

@chrisblossom
Copy link
Author

@timdorr thanks for the suggestion, but from my experience and various best practice articles, using anything expect pinned package versions is not recommended for production apps.

I'll continue to manually check every week or so.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants