Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested u-url gets picked up as source in rss feed #62

Open
aciccarello opened this issue Aug 1, 2023 · 0 comments
Open

Nested u-url gets picked up as source in rss feed #62

aciccarello opened this issue Aug 1, 2023 · 0 comments

Comments

@aciccarello
Copy link

I noticed strange behavior on webmention sending based on my atom feed where one of the targets was getting picked up as the source.

I debugged the code and realized a u-url inside of an h-cite of the post I was replying to was getting picked up as the permalink. It seems like links.js picks up the first u-url which in my case doesn't appear for the post in the feed.

wm/lib/links.js

Lines 16 to 19 in f61809c

let permalink = resolve(
baseHref,
$$.find('.u-url').attr('href') || element.link || ''
);

I was able to resolve the issue by stripping all u-url from the feed, which triggers a fallback to the feed element url, but simply looking for any u-url seems too simple.

aciccarello added a commit to aciccarello/ciccarello.me that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant