You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My current thought is to change the interface signature and make Download work differently. Right now, it returns Task<Stream?>, which prevents the user to inspect the response for errors. It crashes if the call wasn't successful.
So, the idea is to make ExecuteStreamAsync, which will return Task<RestStreamResponse>. The response will be like RestResponse but instead of Content it will have Stream?. Naturally, it requires to be IDisposable.
The first step there was to create a source generator to create instance of RestResponseBase child class, as copying those properties manually is error prone (adding a new prop requires many changes). That part is done, so now this thing should be relatively easy.
My current thought is to change the interface signature and make Download work differently. Right now, it returns
Task<Stream?>
, which prevents the user to inspect the response for errors. It crashes if the call wasn't successful.So, the idea is to make
ExecuteStreamAsync
, which will returnTask<RestStreamResponse>
. The response will be likeRestResponse
but instead ofContent
it will haveStream?
. Naturally, it requires to beIDisposable
.The first step there was to create a source generator to create instance of
RestResponseBase
child class, as copying those properties manually is error prone (adding a new prop requires many changes). That part is done, so now this thing should be relatively easy.Originally posted by @alexeyzimarev in #2072 (comment)
The text was updated successfully, but these errors were encountered: