Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go install failure from avfs #245

Closed
bootswithdefer opened this issue Nov 27, 2024 · 4 comments
Closed

go install failure from avfs #245

bootswithdefer opened this issue Nov 27, 2024 · 4 comments

Comments

@bootswithdefer
Copy link

Attempting to install gilt with go install fails:

# github.com/retr0h/gilt/v2
go: downloading github.com/avfs/avfs v0.33.0
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).SplitAbs: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).cleanGlobPathWindows: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[*github.com/avfs/avfs/vfs/osfs.OsFS]).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs/vfs/osfs.(*OsFS).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
$ go version
go version go1.23.3 linux/amd64
Copy link
Contributor

Thank you for your first issue! 😊🕹️

@0xDEC0DE
Copy link
Contributor

AVFS compatibility with Go 1.23 was fixed in 0.34; we may need another release of Gilt to properly get past it.

@retr0h
Copy link
Owner

retr0h commented Nov 28, 2024

Released gilt v2.2.4 which should fix your problem

Thanks for the report @bootswithdefer, and thanks for the ultimate fix @0xDEC0DE!

❯ mise install [email protected]
mise [email protected] ✓ installed

❯ mise use [email protected]
mise ~/git/gilt/.mise.toml tools: [email protected]

❯ go version
go version go1.23.3 darwin/amd64

❯ go install github.com/retr0h/gilt/v2@latest
go: downloading github.com/retr0h/gilt/v2 v2.2.4
go: downloading github.com/caarlos0/go-version v0.2.0
go: downloading github.com/avfs/avfs v0.35.0

❯ gilt version | jq '.gitVersion'
"v2.2.4"

@retr0h retr0h closed this as completed Nov 28, 2024
@bootswithdefer
Copy link
Author

Works now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants