Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Feedback on url() "decoration" of File: implementation and testing. #19

Open
richardkmichael opened this issue Jan 26, 2013 · 0 comments
Labels

Comments

@richardkmichael
Copy link
Owner

Feedback wanted on the implementation of:

  1. The "decorator" idea to set the url properties of a file: https://github.com/richardkmichael/carrierwave-activerecord/blob/master/lib/carrierwave-activerecord/storage/storage_provider.rb#L31
  2. The reflection on Rails to determine the URL: https://github.com/richardkmichael/carrierwave-activerecord/blob/master/lib/carrierwave-activerecord/storage/storage_provider.rb#L66
  3. The mocking of Rails in the storage provider spec: https://github.com/richardkmichael/carrierwave-activerecord/blob/master/spec/lib/carrierwave-activerecord/storage/storage_provider_spec.rb#L44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant