Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectMerge should consider the impure expression #9181

Open
st1page opened this issue Apr 14, 2023 · 1 comment
Open

ProjectMerge should consider the impure expression #9181

st1page opened this issue Apr 14, 2023 · 1 comment
Assignees

Comments

@st1page
Copy link
Contributor

st1page commented Apr 14, 2023

ProjectMerge, which inlines computation and is the reverse of ColumnDedup/CSE. It adds number of calls, while the latter reduces number of calls. 😅

dev=> explain create materialized view mv as  select y, y as y2 from (select abs(x) as y from t);
                                                             QUERY PLAN                                                              
-------------------------------------------------------------------------------------------------------------------------------------
 StreamMaterialize { columns: [y, y2, t._row_id(hidden)], stream_key: [t._row_id], pk_columns: [t._row_id], pk_conflict: "NoCheck" }
 └─StreamProject { exprs: [Abs(t.x) as $expr1, Abs(t.x) as $expr2, t._row_id] }
   └─StreamTableScan { table: t, columns: [x, _row_id] }
(3 rows)

Originally posted by @xxchan in #9133 (comment)

@github-actions github-actions bot added this to the release-0.19 milestone Apr 14, 2023
@chenzl25 chenzl25 modified the milestones: release-1.0, release-1.1 Jul 14, 2023
@chenzl25 chenzl25 modified the milestones: release-1.1, release-1.2 Aug 2, 2023
@chenzl25 chenzl25 removed this from the release-1.3 milestone Sep 18, 2023
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants