Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The errorMessage will not be cleared after the controlled Form formData changes #4426

Open
4 tasks done
JinYuSha0 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #4429
Open
4 tasks done

The errorMessage will not be cleared after the controlled Form formData changes #4426

JinYuSha0 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #4429
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@JinYuSha0
Copy link

Prerequisites

What theme are you using?

core

Version

5.23.2

Current Behavior

rjsf-issuse

Codesandbox

Expected Behavior

clear error message after onChange, similar to the case where formData is not used
rjsf-issuse2

Steps To Reproduce

No response

Environment

- OS:Windows 22H2
- Node:v22.11.0
- npm:10.8.3

Anything else?

No response

@JinYuSha0 JinYuSha0 added bug needs triage Initial label given, to be assigned correct labels and assigned labels Dec 19, 2024
@JinYuSha0 JinYuSha0 linked a pull request Dec 19, 2024 that will close this issue
8 tasks
@abdalla-rko
Copy link
Contributor

When you don't have the **liveValidate** option enabled the rjsf will only validate on submit. If you want to have live validation, please enable the **liveValidate** option (see demo with live validate)

@JinYuSha0
Copy link
Author

JinYuSha0 commented Dec 20, 2024

Yes I know, If I enable liveValidate, errorMessage will be display when i open the page, I think it would be more reasonable to display it after interaction.

I created a PR to keep the behavior of formData change and Form onChange same, #4429

rjsf-issuse3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants