Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extra pyfilesystem methods to improve efficiency #19

Open
rkhwaja opened this issue Dec 1, 2022 · 1 comment
Open

Implement extra pyfilesystem methods to improve efficiency #19

rkhwaja opened this issue Dec 1, 2022 · 1 comment

Comments

@rkhwaja
Copy link
Owner

rkhwaja commented Dec 1, 2022

  • files_copy_v2 copies files much more efficiently than downloading all the data and uploading it again. copy
  • files_create_folder_batch would improve the speed of makedirs
  • files_delete would improve the speed of removetree and removedir
  • files_move_v2 moves files much more efficiently than the default. Can also move directories
  • walk maybe could use the recursive flag on files_list_folder but there's no override available anyway
@rkhwaja
Copy link
Owner Author

rkhwaja commented May 7, 2023

Reimplementing copydir

default implementation

  • Default implementation contains 2 calls like exists, getinfo which could be amalgamated to one
  • No option on dropbox call to preserve mtime but that might not be honored for all filesystems anyway
  • Can't handle create=False case with Dropbox call - would have to precheck in order to follow the contract and to throw ResourceNotFound
  • Can only precheck for DirectoryExpected, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant