Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pip release? #43

Open
Selur opened this issue Dec 18, 2023 · 6 comments
Open

New pip release? #43

Selur opened this issue Dec 18, 2023 · 6 comments

Comments

@Selur
Copy link

Selur commented Dec 18, 2023

Seeing that 1.6.4 from Jan 25, 2022 is still the current version served by pip and there have been quite a few changes since then, I was wondering if there are any updates for a new pip release are planned. :)

@evolutionaryman
Copy link

I also am curious if this will get updated. :)

@rlaphoenix
Copy link
Owner

Hi, a lot of the commits made after the last release I'm currently unsure-of as in if they actually make a difference good or bad, hence I haven't yet made a stable release for. If you guys don't mind testing it out and seeing if you find any problems, it may speed up release. The main issues I'm concerned with atm is if there's any loss to support for any input/output bit depth or format combinations, and any speed or memory usage changes.

@Selur
Copy link
Author

Selur commented Mar 24, 2024

I can do some testing next week.
Anything a bit more specific to test?
I assumed, so far, input needed to be:
a. mod4
b. RGBS or RGBH
c. pc luma scale

@rlaphoenix
Copy link
Owner

With VSGAN, afair (I havent worked on it or used it in ages), it supports any combination of input format, so long as it wasnt YUV.

@Selur
Copy link
Author

Selur commented Mar 25, 2024

Okay, I tested compatibility only atm.:
input: RGB24, RGB27, RGB30, RGB36, RGB42, RGB48, RGBH, RGBS
2-3 different models per architecture with different scalings.
(for EGVSR. I only used: EGVSR_iter420000.pth)
tested with:
vsgan = ESRGAN(clip=clip,device="cuda")
=> no problems
vsgan = SwinIR(clip=clip,device="cuda")
=> no problem
vsgan = HAT(clip=clip,device="cuda")
=> no problem
vsgan = EGVSR(clip=clip,device="cuda")
=> broken, different colored and wrong output for the tested RGBXX inputs.

@Selur
Copy link
Author

Selur commented Mar 25, 2024

Ran a few speed comparisons with different ESRGAN models and the new one seems to be slightly faster (~1%) for normal models, but a bit faster (~7%) for compact models.
I didn't test EGVSR and the color changing depending on the input is also broken in the old version, but the output wasn't as broken. => EGSVR doesn't seem to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants