Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this Driver Maintained? #72

Open
snoweuph opened this issue Dec 20, 2024 · 18 comments
Open

Is this Driver Maintained? #72

snoweuph opened this issue Dec 20, 2024 · 18 comments

Comments

@snoweuph
Copy link

snoweuph commented Dec 20, 2024

For me it looks like this driver isn't really maintained anymore. taking the source and trying to build it on Kernel 6.12.4 shows me that it doesn't even compile.

Looking at the forks, lets it look like there are some people partially maintaining their forks, but its all spread out, and to get it to work, you have to jump between forks and copy their fixes.

If you as the maintainer don't have the capacity to maintain this anymore, is it maybe possible to get all people interested to work on this together in an last effort, so that they structure themselves to a point where they can take over?

I really would love to work on this, but sadly I've never really worked that low, so I don't really get the code of this. I personally would love to refactor this with good documentation, but looking at it: that would be a pretty big task for somebody not knowing a lot about low level stuff or the kernel at all.

@AdityaGarg8
Copy link

https://github.com/t2linux/apple-ib-drv

It being maintained by t2linux for a long time.

@AdityaGarg8
Copy link

Although, since they have a new driver for touchbar on T2 Macs, that fork is not updated. So if you are on a T2 Mac, t2linux wiki should be good

@AdityaGarg8
Copy link

AdityaGarg8 commented Jan 3, 2025

I'll see if I can PR a compile fix for the older Macs, since I myself am a maintainer at t2linux

@AdityaGarg8
Copy link

https://github.com/AdityaGarg8/apple-touchbar-drv

You can get the fixed and latest maintained version for older non T2 Macs here @snoweuph

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

Im on a Macbook 13,2" Pro Touchbar

@AdityaGarg8
Copy link

Yes it is maintained, but by us (t2linux)

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

ahh okay, good to know

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

which branch of yours should I use though? i gues mbp15 is wrong , after all this is a 13,2 2017 pro model

@AdityaGarg8
Copy link

https://github.com/AdityaGarg8/apple-touchbar-drv

use the main branch from my fork. The I've opened a PR to the t2linux repo mbp15 branch, which is yet to be merged

@AdityaGarg8
Copy link

If you are on Ubuntu you can simply install the apple-touchbar package from my apt repo as well

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

Im using fedora

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

https://github.com/AdityaGarg8/apple-touchbar-drv

use the main branch from my fork. The I've opened a PR to the t2linux repo mbp15 branch, which is yet to be merged

ahh okay

@snoweuph
Copy link
Author

snoweuph commented Jan 3, 2025

Tryed your version on main (dkms, after all im on fedora) and it installed, but its borken under 6.12.6 with it. no dkms and dractur errors with it tough, just that im stuck in lightdm, the login doesnt work with the driver instaled and the ctrl+alt key kombos dont work either

@AdityaGarg8
Copy link

Tryed your version on main (dkms, after all im on fedora) and it installed, but its borken under 6.12.6 with it. no dkms and dractur errors with it tough, just that im stuck in lightdm, the login doesnt work with the driver instaled and the ctrl+alt key kombos dont work either

We haven't really changed any significant code, it's the same as was developed by the author. Only changes requested by upstream have been done. I can't help you to "fix" the driver since I work for T2 Macs, and the sole reason for maintaining this driver is that it also has code for T2.

@AdityaGarg8
Copy link

If you want, I can fix the version in this repo to 6.12

@AdityaGarg8
Copy link

You can try that

@AdityaGarg8
Copy link

AdityaGarg8 commented Jan 3, 2025

If you want, I can fix the version in this repo to 6.12

Or maybe no, it's very old code, not possible to fix now

@AdityaGarg8
Copy link

Probably try blacklisting the drivers and modprobe them one by one to see what's wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants