Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch Zoom to improve #132

Open
YannNeobards opened this issue Jun 7, 2022 · 4 comments · May be fixed by #172
Open

Pinch Zoom to improve #132

YannNeobards opened this issue Jun 7, 2022 · 4 comments · May be fixed by #172
Assignees

Comments

@YannNeobards
Copy link

Hello,

can you improve Pinch zoom events on mobile ?
when you use 2 fingers to zoom on mobile (chrome) the scaling is not done until release
would be great if improved

thanks

@YannNeobards
Copy link
Author

I have fix it quikely (not sure good way) by adding event listener on onAdd(

onAdd(t) {
...
this.isAnimated() && t.on("zoom", this._reset, this),
this.isAnimated() && t.on("move", this._reset, this),

and

onRemove(t)
...
this.isAnimated() && t.off("zoom", this._reset, this),
this.isAnimated() && t.off("move", this._reset, this),

add 'move' event works fine for me to make it works properly with a requestAnimationFrame( changing color and use .render()

@charlieforward9
Copy link
Collaborator

zoom-issue.mov

This is the problem I am facing, I will look where to add in your suggestion to see if it resolves the problem.

@charlieforward9 charlieforward9 self-assigned this Dec 13, 2024
@charlieforward9
Copy link
Collaborator

charlieforward9 commented Dec 13, 2024

0bd9217 includes your snippets, closing this issue.

Please add your email to your profile to be mentioned as a contributor in the commit.

Thank you for the help.

@charlieforward9
Copy link
Collaborator

leaving open till I hear back or it is merged.

charlieforward9 referenced this issue Dec 15, 2024
Co-authored-by: YannNeobards <YannNeobards>
@charlieforward9 charlieforward9 linked a pull request Jan 2, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants