Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CANBUS plugin library #27

Open
7 tasks
triccyx opened this issue Apr 30, 2020 · 7 comments
Open
7 tasks

Create a CANBUS plugin library #27

triccyx opened this issue Apr 30, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@triccyx
Copy link
Member

triccyx commented Apr 30, 2020

Create a CANBUS plugin library.

  • Create repository with make system in Robotology
  • Create library code
  • Create connect block
  • Create write block
  • Create read block with a comparison with expected values
  • Write Xml for ScriptBuilder
  • Write library documentation
@triccyx triccyx added the enhancement New feature or request label Apr 30, 2020
@traversaro
Copy link
Member

traversaro commented Apr 30, 2020

Just to understand, the idea is to use the existing YARP devices that expose the ICanBus interface?
This would be the advantage that we have already maintained backend for the main CAN apis that you support, socketcan and cfw2Can in Linux and ESD CAN SDK on Windows.

@randaz81 randaz81 changed the title Create a CAMBUS plugin library Create a CANBUS plugin library Apr 30, 2020
@triccyx
Copy link
Member Author

triccyx commented Apr 30, 2020

To be honest my idea was to use a CANBUS lib and interact directly with the board in order to test them without any intermediary.
BUT, I think your proposal is interesting (I didn't know that these Yarp components exist).
We can produce two different series of block one for each issue. I expect that the Yarp blocks will be easier to create.

@traversaro
Copy link
Member

Personally I would just develop the block based on the existing YARP drivers to reduce the amount of duplicate code. The code for the can device drivers in icub-main is quite limited (just a small class for each API). If you experience any problem in those drivers, you can fix the problems in the icub-main devices, so that everyone (people using the FirmwareUpdater, robots devices) benefits from the improvements.

@triccyx
Copy link
Member Author

triccyx commented Apr 30, 2020

Not sure, because I would like to permit to test also without Yarp. I will invite you to the meeting when we will speak about this.

@traversaro
Copy link
Member

Hi @triccyx, I guess I can remove this assignment from this issue if no work is planned on this at the moment, right?

@triccyx
Copy link
Member Author

triccyx commented Apr 20, 2021

Yes, agree.
@pattacini will we think about canbus tests or this argument is obsolete?

@traversaro traversaro removed their assignment Apr 20, 2021
@pattacini
Copy link
Member

pattacini commented Apr 20, 2021

@triccyx let's put this in icebox; I don't see now when we can get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants