Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoproj watch gets frozen if the user needs to answer a configuration question #200

Open
doudou opened this issue May 31, 2018 · 5 comments

Comments

@doudou
Copy link
Member

doudou commented May 31, 2018

Ways to fix that:

  • make watch fail in these cases, and wait for more changes. Should display a message that external tools can easily detect and show to the user (e.g. ERROR: <msg>)
  • ?
@g-arjones
Copy link
Contributor

Shouldn't autoproj skip interactive configuration if subcommand == watch?

@doudou
Copy link
Member Author

doudou commented Jun 5, 2018

Skipping the configuration is not really possible. The build setup depends on the configuration, so it can't be loaded or regen'ed.

This is why I was proposing to:

  • detect that interactive configuration is required
  • ignore the update event, and wait for more updates (i.e. user doing the configuration)

Unfortunately, the configuration will also be asked on e.g. update or build, which will have the same problem. Ultimately, we would have to be able to ask for the configuration value.

@g-arjones
Copy link
Contributor

Yes, you are right. I think warning that the build is not properly configured and waiting for another event is the way to go.

@g-arjones
Copy link
Contributor

g-arjones commented Oct 23, 2019

Not an issue anymore, right? @doudou

EDIT: I mean, now that we have --no-interactive

@doudou
Copy link
Member Author

doudou commented Oct 24, 2019

Still an issue, however:

  1. I agree we could probably use --no-interactive to use a temporary configuration until the user does configure (by e.g. running update or build explicitly)
  2. --no-interactive only works for flags that have a default

I guess that doing (1) would still be better than nothing, but (2) will still bite every now and then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants