-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression : Executor::spin_some_impl is active waiting #2508
Comments
@wjwwood Could you please handle this issue? |
Small update, I've iterated on the original pr to fix this here: #2517 Waiting to get it reviewed before merging it. |
@wjwwood i will try to taka a look in this week. thanks! |
Thanks @fujitatomoya, as always more reviews (even post merge reviews) are welcome, but @mjcarroll reviewed it already too. |
Closed with #2517 |
This was introduced in #2142
rclcpp/rclcpp/src/rclcpp/executor.cpp
Line 383 in 3d58f0f
This condition make the executor active spin until the time is over if used in spin_all.
I guess
is the correct implementation.
The text was updated successfully, but these errors were encountered: