[20706] Make reader get_first_untaken_info() coherent with read()/take() #4696
+125
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Apr 17, 2024
Signed-off-by: Mario Dominguez <[email protected]>
fujitatomoya
approved these changes
Apr 18, 2024
|
@richiprosima Please test this |
MiguelCompany
approved these changes
Apr 19, 2024
|
Unrelated failures. Going in. |
|
@Mergifyio backport 2.13.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e)
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e)
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e)
This was referenced Apr 19, 2024
Merged
Merged
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 19, 2024
…#4707) * Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e) Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 23, 2024
…#4708) * Make `get_first_untaken_info()` coherent with `read()/take()` (#4696) * Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e) * Refs #20706: test fix Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
EduPonz
pushed a commit
that referenced
this pull request
May 9, 2024
…#4706) * Refs #20706: Add regression BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20706: Apply review suggestions Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 5fbd88e) Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the behavior of
get_first_untaken_info()so that it retrieves the first valid cache change (checking whether the change is in the future or not), instead of just returning the first one in the instance (sorted by sourcetimestamp).In the scenario of having multiple reliable writers and one reader with history size > 1 in the same topic, it can happen that
get_first_untaken_info()returnsOK(as it is not currently checking whether the change is in the future) buttake()returnsNO_DATAbecause the change is in the future.In addition, a brief doxygen documentation is added to be aware that the method is meant to be followed by a
read()ortake()since it does not modify the status condition of the entity.@Mergifyio backport 2.13.x 2.10.x 2.6.x
Fixes ros2/rmw_fastrtps#749
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist