Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copy option to Audio Codec. Add Crop option to Arguments #546

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

brett-baker
Copy link
Contributor

Added copy option to the available audio codecs.

Added basic crop functionality to the to the available arguments.

upgraded system.text.json version to 7.0.3.

brett-baker and others added 5 commits November 1, 2024 09:13
Add the option to crop the video to a given size.
If the title is missing from the analysis metadata, the analysis fails.  Added null check and default value of "TitleValueNotSet".
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (f8407bc) to head (5d654af).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
FFMpegCore/FFMpeg/Arguments/CropArgument.cs 0.00% 8 Missing ⚠️
FFMpegCore/FFMpeg/FFMpegArgumentOptions.cs 0.00% 4 Missing ⚠️
FFMpegCore/FFMpeg/Enums/Enums.cs 0.00% 2 Missing ⚠️
FFMpegCore/FFProbe/MediaAnalysis.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   74.31%   70.70%   -3.62%     
==========================================
  Files         113      116       +3     
  Lines        2854     2942      +88     
  Branches        0      279     +279     
==========================================
- Hits         2121     2080      -41     
- Misses        733      754      +21     
- Partials        0      108     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosenbjerg rosenbjerg merged commit 10bc004 into rosenbjerg:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants