Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uap is missing in 2.0.0.14 #707

Closed
2 of 7 tasks
DevEddy opened this issue Oct 20, 2021 · 21 comments
Closed
2 of 7 tasks

uap is missing in 2.0.0.14 #707

DevEddy opened this issue Oct 20, 2021 · 21 comments

Comments

@DevEddy
Copy link
Contributor

DevEddy commented Oct 20, 2021

🐛 Bug Report

Error CS0234 The type or namespace name 'Popup' does not exist in the namespace 'Rg.Plugins.Popup' (are you missing an assembly reference?)

Package Content 2.0.0.13 (uap included):
image

Package content 2.0.0.14 (no uap):
image

Expected behavior

No error

Reproduction steps

Use Xamarin.Forms UWP and Rg.Plugins.Popup 2.0.0.14

Configuration

Version: 2.0.0.14

Platform:

  • 📱 iOS
  • 🤖 Android
  • 🏁 WPF
  • 🌎 UWP
  • 🍎 MacOS
  • 📺 tvOS
  • 🐒 Xamarin.Forms
@PrinceCharles23
Copy link

cannot confirm the source of the issue (since i have not checked) but the behaviour - was introduced in 2.0.0.14 and is working in 2.0.0.13

@softlion
Copy link
Contributor

Confirmed. Any workaround except downgrading ?

image

@avorobjovs
Copy link

I confirm this issue.

@Agredo
Copy link

Agredo commented Oct 27, 2021

I can confirm this! Updating directly to 2.0.0.14 will cause this. Downgrading to 2.0.0.13 works!

@cbs-cbt
Copy link

cbs-cbt commented Oct 27, 2021

I confirm this issue.

Error CS0234 :
The type or namespace name 'Popup' does not exist in the namespace 'Rg.Plugins.Popup' (are you missing an assembly reference?)

When compiling for UWP with version 2.0.0.14

@FrozDark
Copy link

UWP reference miss confirmed

@vividos
Copy link

vividos commented Nov 7, 2021

It may be that the build of the NuGet package was done on a Mac, since the UAP assembly is missing in 2.0.0.14. This line takes care that on Mac there is no UWP build:

<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">uap10.0.17763;$(TargetFrameworks)</TargetFrameworks>

@LuckyDucko
Copy link
Collaborator

LuckyDucko commented Nov 12, 2021

Hey guys, sorry for a late reply.

I have updated the latest github package to add on a windows built version of 2.0.0.14. It has 'rebuilt' added within its name. Just remove that and add it manually and hopefully that helps out. I do not have access to the nuget so unfortunately this is the best i can do.

@vividos good call concerning the building issue, lets see if it works out!

@SBurgos00
Copy link

Is the rebuilt package working for anyone? I still have the same error when using it.

This is what I did to use the new package:
-Download rebuilt package
-Removed ".rebuilt" from the name
-Added a package source for the downloaded package and moved it to the top of the list of sources
-Uninstalled the existing package from all projects
-Clean solution
-Set package manager source to the one I set up above
-Installed the package to all project
-Rebuild

@kyurkchyan
Copy link

I can confirm this issue as well. As soon as I downgrade to 2.0.0.13 the issue is gone

@LuckyDucko
Copy link
Collaborator

@SBurgos00 @kyurkchyan
do you still get the same error? i did some testing on my windows computer after i built it, just against the rg demo app.

I worry i may have missed something obvious, and do apologise that such a large bug has been introduced, i have just had no time for this, let alone the MAUI upgrade i want to be doing.

I do plan on giving this a renewed focus when i'm on leave in Jan, however, i can give this another look on Sunday, and hope that things work out.

Can you try just downloading the develop branch and then referencing it as a project in your solution? I know its much less of a solution than with the nuget, however it may get you up and running for the time being

@SBurgos00
Copy link

@LuckyDucko Later I downloaded the source and added the project to my solution and referenced it in my UWP project. It was able to build and run. I'm going to use it that way for now. It is weird that it didn't work as a Nuget. Don't worry about looking at this on Sunday for just me. Thanks!

@LuckyDucko
Copy link
Collaborator

@SBurgos00 glad it worked out. I'll give it a test using my own application just to be sure now, if 1 person mentions it, 100 people have had the same issue and have been quiet.

@kevcrooks
Copy link

@LuckyDucko is it possible to get a nuget release with the fix? We'd like to use it in our build pipeline, but I think manually downloading would only work locally? Glad to find this issue though, we were slightly confused initially!

@LuckyDucko
Copy link
Collaborator

@kevcrooks

Ah, i can try and pull one of these out for you, however i wont be able to update on nuget.org, as only @martijn00 can do that

@egvijayanand
Copy link

Is the rebuilt package working for anyone? I still have the same error when using it.

This is what I did to use the new package: -Download rebuilt package -Removed ".rebuilt" from the name -Added a package source for the downloaded package and moved it to the top of the list of sources -Uninstalled the existing package from all projects -Clean solution -Set package manager source to the one I set up above -Installed the package to all project -Rebuild

How to download the rebuilt package, what's the command to invoke the same?

As I face the same issue with v2.0.0.14 with the UWP project whereas v2.0.0.13 works fine. Want to try the rebuilt package.

@mfeingol
Copy link

Looks like version 2.1.0 has the same problem.

@avorobjovs
Copy link

Looks like version 2.1.0 has the same problem.

No, it isn't. But you need to set the TargetPlatformMinVersion to 10.0.18362.0 for the UWP project.
Only this UWP version has 2.1.0 packages.

UWP_2 1 0

For some reason, the author forgot to mention this. :)

@mfeingol
Copy link

@avorobjovs: confirmed, thanks.

@gceaser
Copy link

gceaser commented Feb 4, 2022

I can confirm that after updating to version 2.1.0, I needed to update the TargetPlatformMinVersion to 10.0.18362.0 for the UWP project. Then everything compiled correctly. The UWP initialization instructions should probably be updated with this information.

@egvijayanand
Copy link

Yes, package dependencies in the NuGet page confirm the same.

https://www.nuget.org/packages/Rg.Plugins.Popup/2.1.0#dependencies-tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests