Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing code fix (millis till ready / "warmed up" in loop vs burst count) #95

Closed
kenchong48 opened this issue Jul 29, 2022 · 5 comments
Closed
Assignees

Comments

@kenchong48
Copy link
Contributor

No description provided.

@kenchong48
Copy link
Contributor Author

Will use Ken's code for timing for now

@ZavenArra
Copy link
Contributor

I don't understand what this issue is about right now, can you describe the problem? We made some hack to get around something here?

@kenchong48
Copy link
Contributor Author

I believe this was an issue of when is a sensor ready to take samples, vs when is it warmed up (how often/when do we check when it is warmed up), vs how often does a user want to take samples. Across different sensors we could have wanting to take analog readings very fast, as compared to a sensor that can only give samples every 2 seconds

What I implemented only takes samples when the slowest sensor is ready to take readings, and does not log extra values in between that, I don't think this accounts for if all sensors are analog and can read continuously though.

The code for mixing and matching these speeds is something you said you would think through.

@kenchong48
Copy link
Contributor Author

kenchong48 commented Oct 20, 2022

Oh, we actually have a different item to look at the reading cycles delay #88 ... I'm not sure what this is then

@ZavenArra
Copy link
Contributor

Closing this issue as not specific enough.

Repository owner moved this from Todo to Done in RRIV General Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants