Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use "cosmo" bootswatch only if neither preset nor bootswatch are set #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Oct 4, 2023

This is a small change that will be transparent to most users that avoids errors if setting the theme: preset key. Currently, because bslib errors if preset and bootswatch are both set, and because bootswatch: cosmo is set by default by flexdashboard, users would need to write

output:
  html_document:
    theme:
      version: 5
      preset: shiny
      bootswatch: ~

to avoid the error from bslib. After this change, the bootswatch: ~ line isn't needed.

@gadenbuie gadenbuie requested a review from cpsievert October 4, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant