Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connecting using options other than :host and :port, error messages always refer to default host and port #133

Closed
robbavey opened this issue Jul 31, 2018 · 5 comments

Comments

@robbavey
Copy link

When connecting to MarchHare, specifying host and port by means other than :host/:port, result in error messages referring to the default host and port, rather than those passed in.

For example,

jruby-9.1.14.0 :018 > conn = MarchHare.connect(:addresses => ["invalid_host:999"])

Results in the following error:

MarchHare::ConnectionRefused: Connection to localhost:5672 refused: host unknown

Similarly, using

jruby-9.1.14.0 :019 > conn = MarchHare.connect(:hosts => ["invalid_host"])
MarchHare::ConnectionRefused: Connection to localhost:5672 refused: host unknown

Specifying a working rabbitmq instance in those parameters results in a valid connection.

@michaelklishin
Copy link
Member

I can reproduce, thank you.

@psych0d0g
Copy link

nearing the issues birthday, ive just got bitten by it today and wasted around an hour on debugging, any plan to fix this?

@michaelklishin
Copy link
Member

@psych0d0g this is open source software, so you are welcome to contribute. I do not make any ETA promises and unless an issue is critical, we get to them when we get to them.

@michaelklishin michaelklishin added this to the 4.1.0 milestone Jul 9, 2019
@mikearruda
Copy link

nearing the issues birthday, ive just got bitten by it today and wasted around an hour on debugging, any plan to fix this?

@psych0d0g As suggested by @jsvd in logstash-plugins/logstash-output-rabbitmq#76 (comment), just remove the port option and pass the port in the host field like "host:port". I have confirmed this is working for me.

@michaelklishin
Copy link
Member

michaelklishin commented Jul 12, 2019

4.1.0 will print the entire effective list of addresses instead of default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants