-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues with Active Rails Ch3 #20
Comments
Thanks for your suggestions. We will look at adding them to the book. |
This
We will need to fix that one.
This will need to be fixed too.
Thanks, we'll do that.
Good point. We'll need to update that.
We'll need to check this one out. |
Heya Peeps! thought I should pass along feedback as I go.
also an fyi incase you found it useful feedback from a reader/ implementer, I am keeping a working doc of things covered at https://github.com/CoderCarl1/Active_rails_proj1
Issues in Ch3
===
3.1.1 The application Story
p62 - advises to run : rails 6.0.2.2 new ticketee, is this supposed to be rails new ticketee??
===
3.2.2. Configuring your Git client
p66 - commit ID inside the snippet, a different commit ID directly below in the text
- You are advised to run git log , suggestion: also include how to exit VIM :q
p67 unsure, but maybe need to update the git repo address to follow along with
===
3.3.1. The Gemfile and generators
p68-70 -gemfile shows ruby '2.6.5' but you have previously advised to use '2.7.0'
-explanation advises it requires rails 6.0.2.2 but the snippet is >=6.0.2.1
-Unsure if it is too much info as all parts are not highlighted/ explained. Looks messy when new page required for part of snippet and that part is not relevant
-Suggestion to remove version numbers from your explanations unless feature dependant.
===
3.3.2. Database configuration
p73 Updating config/database.yml to postgresql
- may want to re-inforce that you need to update the gemfile i.e. include 'pg' for PostgreSQL (unsure what the gem is for MYSQL)
===
3.4.2. RESTful routing
p87 You change from bundle exec rake db:migrate (which will prevent future issues, YAY!) to rails db:migrate without explanation
===
3.4.3. Committing changes
p100 your code snippet uses find_by and then you immediately reference it as "find_by!"
The text was updated successfully, but these errors were encountered: