Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe get_raw_transaction should return Result<Option<Transaction>, Error>? #191

Open
Kixunil opened this issue Jul 29, 2021 · 0 comments
Open

Comments

@Kixunil
Copy link

Kixunil commented Jul 29, 2021

It may be more natural to return None instead of Err if the transaction wasn't found similarly to how HashMap returns None instead of Err. This is loosely related to romanz/electrs#446 (comment) - the case when transaction is not found may not be exactly erroneous and may need special handling more often than other errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant