Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86_64 msvc: warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC #134657

Open
jieyouxu opened this issue Dec 22, 2024 · 4 comments · Fixed by rust-lang/cc-rs#1330
Labels
C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Dec 22, 2024

On my native x86_64-pc-windows-msvc environment, I am observing the warnings:

   Compiling rustc_ast_passes v0.0.0 (X:\repos\rust\compiler\rustc_ast_passes)
   Compiling rustc_expand v0.0.0 (X:\repos\rust\compiler\rustc_expand)
   Compiling rustc_builtin_macros v0.0.0 (X:\repos\rust\compiler\rustc_builtin_macros)
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
warning: [email protected]: Inherited flag "/Oy-" is not supported by the currently used CC
   Compiling rustc_infer v0.0.0 (X:\repos\rust\compiler\rustc_infer)
   Compiling rustc_mir_dataflow v0.0.0 (X:\repos\rust\compiler\rustc_mir_dataflow)
   Compiling rustc_metadata v0.0.0 (X:\repos\rust\compiler\rustc_metadata)
   Compiling rustc_pattern_analysis v0.0.0 (X:\repos\rust\compiler\rustc_pattern_analysis)

This is probably related to the cc bumps we done recently... FYI @clubby789 :ferrisClueless: I have not tried to bisect this.

@jieyouxu jieyouxu added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 22, 2024
@jieyouxu jieyouxu added O-windows-msvc Toolchain: MSVC, Operating system: Windows and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 22, 2024
@clubby789
Copy link
Contributor

Yeah these warnings come from cc trying to pass through the equivalent flags (observed while debugging the recent bump). cc probes them and emits this warning if it can't pass the flags through.

Not sure if this is necessarily something to worry about - maybe cc could provide more options to configure this behaviour

@clubby789
Copy link
Contributor

/Oy enables frame-pointer omission and /Oy- disables omission. In x64 compilers, /Oy and /Oy- are not available.

Hmm, maybe CC should be applying some more heuristics to these inherited flags

@jieyouxu
Copy link
Member Author

Yeah, I just wanted to track it in case it's problematic.

@clubby789
Copy link
Contributor

Oops - probably want to keep this open until it makes it into a release that we can pull in.

@clubby789 clubby789 reopened this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants