Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify unit test cases of QueueState and QueueStateSync #122

Open
jiangliu opened this issue Nov 26, 2021 · 1 comment
Open

Unify unit test cases of QueueState and QueueStateSync #122

jiangliu opened this issue Nov 26, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jiangliu
Copy link
Member

One review comments for #120
Hmm, looks like most of the tests here would apply to other QueueStateT implementations just as well. It would actually be great to have a battery of tests for the QueueStateT interface that can then be reused to test all implementations (so far there's QueueState and QueueStateSync), and then separate tests for stuff that's specific to QueueStateSync in particular (altho there's not that much truly specific stuff IMO; even the test where multiple threads are spawned can be seen as generic due to lock being part of the high level interface).

Not sure exactly just how much effort that would require, so maybe doing it as part of this PR is not the best approach, but then I think we should at least have an issue and tackle it b4 publishing.

@andreeaflorescu
Copy link
Member

For now we should start with de-duplicated the following tests that are exactly the same (except for the initialization):

We can work next on having all the tests ported to the queue guard as well. This should be though a separate issue.

@andreeaflorescu andreeaflorescu added the good first issue Good for newcomers label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants