Skip to content

Latest commit

 

History

History
176 lines (118 loc) · 7.31 KB

README.md

File metadata and controls

176 lines (118 loc) · 7.31 KB
Raw

GAS HR

Summary

  1. Abstract
  2. Setup
    1. Environment Variables
    2. Depencencies
    3. Clasp
  3. Development
    1. Directory Structure
    2. Formatting and Conventions
    3. Commit Messages
    4. Deploying to GAS
    5. Workflow

Abstract

This repository is the Google Apps Script code for the main spreadsheet used by the Human Resources department at SA-SEL. It's main features are related to managing SA-SEL's members and projects and their data.

Setup

In order to contribute to this project and code locally using autocompletion, you must execute a couple of simple steps to set it up.

Environment Variables

Provide a .env file in the same format as the .env.example:

cp .env.example .env

In this file, you must specify the SCRIPT_ID1 to the project you're working on. Create a copy of the project's main Google Sheet for you to work on and provide that Sheet's script's ID.

Dependencies

The project has lots of dependencies, as listed in package.json. In order to install them, run:

npm install

This command will also link your local environment to the project with specified ID (see previous section).

Development

Directory Structure

The script's entrypoint is src/index.ts, but this file does not contain any code per se - it only exports all of the project's features, so all relevant code will be injected into it in compile time.

The actual code lies inside the directories of src/:

  • utils/: utility components that'll be used in multiple parts of the code (e.g.: functions to add or remove data from sheets, etc)
  • core/: the actual features (e.g.: onOpen function, or a function to be executed in a button)
  • models/: enums and type objects

Each of those directories has a path alias set (@utils, @core and @models), so you should import using these unless you're in the same directory, in which case you'll use the relative path (./path/to/module) in order to avoid circular dependencies.

Whenever you create a new module, you should "re-export" all of it's exports from their directory's index.ts.

PS: If you wanna see how all of those files are merged into one, run

npm run build

and see the file .build/index.js.

Formatting and Conventions

We're using ESLint for linting and Prettier for autoformatting. Download and configure their extensions for your IDE - e.g.: for VSCode there is Prettier and ESLint.

Aside from that, document your code with TSDoc-style comments and use ES6 syntax.

Commit Messages

Write commit messages following the following convention:

Commit title

The commit message must be written in english and with the following format

<type>(<optional scope>) [<ISSUE>] Commit message

For example, when working on a task #7, you commit the creation of a view that previews an email: feat(email) #7: Create "email preview" view.

Aside from that, be sure to make use of git commit --amend and --no-edit when necessary. Write commit message that actually describe (summarize) the changes you made - do not commit stuff like Fix bug, Fix, Fix bug 3, Fix bug (again).

The message's fields are described in detail below. For more reference, see this style guide and the Angular commit message guidelines.

This commit message convention will be checked via git hooks.

<type> field

O campo type deve ser uma das seguintes opções:

  • build: changes to the build system or dependencies;
  • chore: maintenance/technical task that does not necessarily relate to a user story/new feature;
  • ci: changes to the CI/CD (GitHub actions) config files and scripts;
  • docs: documentation changes;
  • feat: a new feature;
  • fix: a bug fix;
  • perf: a code change that improves performance;
  • refactor: a code change that neither fixes a bug nor adds a feature;
  • style: changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc).

(<scope>) field

The scope field is optional and must consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser).

<ISSUE> field

It must be the issue code - e.g. #7.

Commit message field

This is the actual message that must summarize the code changes in a short phrase. The message must follow the rules:

  • Be capitalized;
  • Be in english;
  • Use the imperative present tense (e.g. "change" instead of "changed" or "changes");
  • No trailing punctuation (period, exclamation, etc);
  • Be at most 60 characters long;

Deploying to GAS

In the Dependencies section, you linked your local environment to the GAS project. If you ever change the SCRIPT_ID and need to re-link, either run npm install again or scripts/setup-clasp.sh.

To deploy your code to the GAS project after you edited it, simply run:

npm run push

PS: You don't need to deploy to the project's main script - it will be done every time a PR is merged to the main branch.

Deploying to GAS

In the Dependencies section, you linked your local environment to the GAS project. If you ever change the SCRIPT_ID and need to re-link, either run npm install again or scripts/setup-clasp.sh.

To deploy your code to the GAS project after you edited it, simply run:

npm run push

PS: You don't need to deploy to the project's main script - it will be done every time a PR is merged to the main branch.

Workflow

  1. Clone the repository
  2. Choose a task you want to work in the board
    • The task must be in the 'To do' column and have no assignees
    • Prioritize tasks with higher priority: enhancement < moderate < important < critical
    • Check if the task has any dependencies and, if so, their dependencies were already closed
  3. Assign the task to yourself and move it to the 'In progress' column
  4. Create a new branch with the format issue-<ISSUE/TASK_NUMBER>
  5. Make all your changes in that branch
  6. Merge the main into your branch
  7. git fetch --all
  8. git merge origin main
  9. Resolve merge conflicts
  10. git commit (use default commit message)
    1. git push --set-upstream origin issue-<ISSUE/TASK_NUMBER>
    2. Make a PR
      • Follow the instructions in the PR template
      • Move the task to the 'In PR' column in the board
    3. Request the director's review
    4. Merge your PR only when:
      • It was approved (in code review)
      • All CI checks have succeeded
      • There are no merge conflicts

Footnotes

  1. e.g.: https://script.google.com/home/projects/SCRIPT_ID/edit ↩